docs(sidenav): update responsive example to use current APIs#33318
docs(sidenav): update responsive example to use current APIs#33318EduardF1 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I've signed the Google CLA. @googlebot please check. If it doesn't retrigger automatically, could a maintainer re-run the CLA check? Thanks! |
|
I have signed the Google CLA. |
Replaces the manual MediaMatcher/MediaQueryList setup with the CDK's BreakpointObserver.observe(), which is the idiomatic Angular approach. Uses takeUntilDestroyed() for automatic subscription cleanup, removing the need to implement OnDestroy and manually manage event listeners. Fixes angular#29266 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
EduardF1
force-pushed
the
docs/update-responsive-sidenav-example
branch
from
fc2eb8f to
ff0fc7d
Compare
|
Update: I have already signed the Google CLA with fischerszavarduard@gmail.com, and I have now rewritten this PR commit so the author/committer email matches that signed address. The cla/google check is still failing. Could a maintainer please re-run or investigate? |
1 participant
Summary
Updates the responsive sidenav documentation example to use the current CDK APIs instead of deprecated MediaMatcher/MediaQueryList event listener methods.
Root Cause
The example was using MediaMatcher with addEventListener/removeEventListener, which requires manual lifecycle management via OnDestroy. An Angular team member noted the preferred approach is to use the CDK's BreakpointObserver.observe() directly.
Changes
Result
The component is now simpler, idiomatic Angular, and no longer uses the raw MediaQueryList API.
Fixes #29266